Skip to content
This repository was archived by the owner on Mar 13, 2025. It is now read-only.

Issue #45 #98

Merged
merged 4 commits into from
Feb 17, 2021
Merged

Issue #45 #98

merged 4 commits into from
Feb 17, 2021

Conversation

yoution
Copy link
Contributor

@yoution yoution commented Feb 14, 2021

No description provided.

Copy link
Contributor

@maxceem maxceem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yoution great solution!

Generally, it works great and I found only one drawback. When we move the mouse across several skills many popups are shown and all it looks like stuck, see video https://monosnap.com/file/HqXZvLjmAITgT1stiFE2yGp7cSAfw9

To solve it I suggest showing the skills popup with some delay, i. e.:

  • we put the mouse on the skills
  • wait a bit 100ms - 1000ms (we have to find which value is small, but enough)
  • if the cursor was not moved out, then show popup

Also, please kindly check the comments to the code below.

@yoution yoution requested a review from maxceem February 17, 2021 14:02
Copy link
Contributor

@maxceem maxceem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yoution thank you for the quick update. Nice idea to reduce the close delay, but it's hard now to see all the skils if we move the cursor not vertically, but from the side, see demo video https://monosnap.com/file/kbqRDEQbKHsF1uJci049nD9I3gpw9K

Also, a couple of more notes for the code below.

@yoution yoution requested a review from maxceem February 17, 2021 14:34
Copy link
Contributor

@maxceem maxceem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @yoution, works great now!

@maxceem maxceem merged commit cd5941f into topcoder-archive:dev Feb 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants